bonkmaykr/ojrc
1
0
Fork 0
mirror of https://git.ngram.ca/OpenJam/rc-servers synced 2026-08-23 23:08:52 +00:00
Code Activity

Add validation warning about fake players on strange teams in any game mode

Browse Source
This commit is contained in:
NG (Graham)
2025-10-30 22:15:12 -04:00
parent 3fb2fbad06
commit 77b6d8c11f
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
rc_core/src/persist/combat.rs
View File

@@ -192,7 +192,7 @@ impl super::config::SelfValidator for GameEvents {
.any(|(i2, f2)| i != i2 && f.team == f2.team)) { .any(|(i2, f2)| i != i2 && f.team == f2.team)) {
info.warn(crate::persist::config::ValidationMessage { info.warn(crate::persist::config::ValidationMessage {
path: vec!["multiplayer".to_owned(), "mode".to_owned()], path: vec!["multiplayer".to_owned(), "mode".to_owned()],
message: format!("Multiplayer game mode {:?} does not work well with more than one player per team", self.multiplayer.mode), message: format!("Multiplayer game mode {:?} does not work well with more than one (fake) player per team", self.multiplayer.mode),
}); });
} }
if ctx.multiplayer.fakes.iter().any(|f| matches!(f.implementation, super::multiplayer::ClientEmulation::ClientAI)) { if ctx.multiplayer.fakes.iter().any(|f| matches!(f.implementation, super::multiplayer::ClientEmulation::ClientAI)) {
@@ -201,6 +201,13 @@ impl super::config::SelfValidator for GameEvents {
message: format!("Multiplayer game mode {:?} does not work well with client-side AI", self.multiplayer.mode), message: format!("Multiplayer game mode {:?} does not work well with client-side AI", self.multiplayer.mode),
}); });
} }
} else {
if ctx.multiplayer.fakes.iter().any(|f| f.team.is_some_and(|t| t > 1)) {
info.warn(crate::persist::config::ValidationMessage {
path: vec!["multiplayer".to_owned(), "mode".to_owned()],
message: format!("Multiplayer game mode {:?} does not work well with (fake) players split between more than 2 teams", self.multiplayer.mode),
});
}
} }
is_ok is_ok
} }